[YUNIKORN-2366] Update GetPodResources() to handle in-place pod resource updates #770
+199
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcondit
force-pushed
the
YUNIKORN-2366
branch
from
ccdef2c to
d5a9a80
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 70.94% 71.02% +0.07%
==========================================
Files 43 43
Lines 7652 7686 +34
==========================================
+ Hits 5429 5459 +30
- Misses 2021 2024 +3
- Partials 202 203 +1 ☔ View full report in Codecov by Sentry. |
chia7712
reviewed
Jan 28, 2024
…rce updates Implement initial support for the upcoming Kubernetes InPlacePodVerticalScaling feature when doing Pod resource calculations. If present, the allocated resources of each container will be used in preference to the requested resources. Additionally, if the Pod status flag Resize is set to Proposed, use the larger of both requested and allocated for each resource type.
craigcondit
force-pushed
the
YUNIKORN-2366
branch
from
d5a9a80 to
aa83f75
Compare
chia7712
reviewed
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Implement initial support for the upcoming Kubernetes InPlacePodVerticalScaling feature when doing Pod resource calculations. If present, the allocated resources of each container will be used in preference to the requested resources. Additionally, if the Pod status flag Resize is set to Proposed, use the larger of both requested and allocated for each resource type.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2366
How should this be tested?
Added unit tests to cover logic introduced by the upstream K8s feature.
Screenshots (if appropriate)
Questions: